Add test for --test-builder success path #148608
Open
+59
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
Collaborator
|
|
Collaborator
This comment has been minimized.
This comment has been minimized.
osamakader
force-pushed
the
doc-test-builder
branch
from
97b721d to
a95ac0c
Compare
This comment has been minimized.
This comment has been minimized.
Adds missing test coverage for rustdoc's `--test-builder` option. The existing test only covered the error case (non-executable builder). This PR adds: - A custom test builder that logs arguments and forwards to rustc - A test verifying that `--test-builder` successfully invokes the custom builder with rustc-style arguments - Improved comments explaining both the error and success test scenarios The test validates that custom builders can properly intercept and handle doctest compilation. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
osamakader
force-pushed
the
doc-test-builder
branch
from
a95ac0c to
8075c98
Compare
Member
|
r? rustdoc |
rustbot
added
the
T-rustdoc
GuillaumeGomez
approved these changes
Nov 7, 2025
Member
|
Much appreciated, thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 7, 2025
…llaumeGomez Add test for --test-builder success path Fixes rust-lang#148586
bors
added a commit
that referenced
this pull request
Nov 7, 2025
Rollup of 5 pull requests Successful merges: - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro) - #148204 (Modify contributor email entries in .mailmap) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148608 (Add test for --test-builder success path) r? `@ghost` `@rustbot` modify labels: rollup
| let builder_bin = path("builder-bin"); | ||
| rustc().input("builder.rs").output(&builder_bin).run(); | ||
|
|
||
| let log_path = path("builder.log"); |
Contributor
Author
There was a problem hiding this comment.
I’m doing that intentionally, so each test run starts with no builder.log. The custom builder writes the log using fs::write(&log_path, ...), which creates the file fresh with only the arguments from the current run. If we left an old log in place, we might inadvertently read stale content from a previous run.
Member
bors
added
S-waiting-on-author
Contributor
Author
|
I'm trying right now to use bare_rustc so we compile for the host architecture even in cross build. |
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148586